Require explicit override decorator#1255
Merged
Fizzadar merged 12 commits intopyinfra-dev:3.xfrom Mar 27, 2025
Merged
Conversation
Member
|
I think this is a good change, an explicit typing improvement with no actual functionality change. Only concern might be breaking type-checking with other modules but that doesn't fall under the version compatibility anyway so probably OK... |
24740a3 to
75254cb
Compare
75254cb to
b9fa3a9
Compare
Contributor
Author
|
Well, it passes the pipeline now, but locally I still get some errors: So I'm guessing there's some different version of greenlet installed in my container ? |
Member
They look unrelated though? Possibly greenlet related, I'll pull this and poke at it a bit when I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is a good idea, hence a draft MR, there would be some 304 missing
@overridedecorators.